Skip to content

[GLUTEN-11683][VL] Enable GlutenParquetTypeWideningSuite for Spark 4.0 and 4.1#11684

Merged
baibaichen merged 2 commits intoapache:mainfrom
baibaichen:pr1/enable-parquet-type-widening-suite
Mar 8, 2026
Merged

[GLUTEN-11683][VL] Enable GlutenParquetTypeWideningSuite for Spark 4.0 and 4.1#11684
baibaichen merged 2 commits intoapache:mainfrom
baibaichen:pr1/enable-parquet-type-widening-suite

Conversation

@baibaichen
Copy link
Contributor

@baibaichen baibaichen commented Mar 3, 2026

What changes were proposed in this pull request?

Enable GlutenParquetTypeWideningSuite (84 tests) for Spark 4.0 and 4.1, validating Parquet type widening support (SPARK-40876).

Changes

  1. Exception translation (ClosableIterator.java + ColumnarBatchOutIterator.java):
    Add translateException() virtual hook to convert Velox type conversion errors to SchemaColumnConvertNotSupportedException.

  2. Enable suite (VeloxTestSettings.scala for spark40/spark41):
    Enable suite with 63 excludes for tests not yet supported by Velox.

  3. Build improvement (builddep-veloxbe-inc.sh):
    Target specific CMake build targets for faster incremental builds.

Test Results

Spark 4.0 Spark 4.1
✅ Passed 21 21
❌ Excluded 63 63
Total 84 84

The 63 excluded tests require Velox C++ type widening support and will be addressed in follow-up PRs.

Fixes #11683

How was this patch tested?

Ran GlutenParquetTypeWideningSuite locally for both Spark 4.0 and 4.1: 21 pass / 0 fail / 63 ignored.

Was this patch authored or co-authored using generative AI tooling?

Yes, co-authored with GitHub Copilot.

@github-actions github-actions bot added CORE works for Gluten Core VELOX labels Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Run Gluten Clickhouse CI on x86

@baibaichen baibaichen force-pushed the pr1/enable-parquet-type-widening-suite branch from bb4c852 to ed359a2 Compare March 4, 2026 13:32
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Run Gluten Clickhouse CI on x86

Copy link
Member

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@baibaichen baibaichen force-pushed the pr1/enable-parquet-type-widening-suite branch from ed359a2 to ba6f68b Compare March 6, 2026 09:28
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Run Gluten Clickhouse CI on x86

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@baibaichen baibaichen force-pushed the pr1/enable-parquet-type-widening-suite branch from ba6f68b to 115b01f Compare March 8, 2026 01:45
@github-actions github-actions bot added the BUILD label Mar 8, 2026
@github-actions
Copy link

github-actions bot commented Mar 8, 2026

Run Gluten Clickhouse CI on x86

@baibaichen baibaichen force-pushed the pr1/enable-parquet-type-widening-suite branch from 115b01f to 89628ce Compare March 8, 2026 02:20
@github-actions
Copy link

github-actions bot commented Mar 8, 2026

Run Gluten Clickhouse CI on x86

@baibaichen baibaichen force-pushed the pr1/enable-parquet-type-widening-suite branch from 89628ce to 556c23a Compare March 8, 2026 06:26
Add translateException() to ClosableIterator as a virtual hook for
backend-specific exception translation. Override in ColumnarBatchOutIterator
to translate Velox type conversion errors into Spark's
SchemaColumnConvertNotSupportedException.

Exclude 63 tests: Velox native reader always rejects incompatible type
conversions (no parquet-mr fallback), and does not support
DELTA_BYTE_ARRAY encoding for FIXED_LEN_BYTE_ARRAY decimals.

Test results: 21 pass / 63 ignored (spark40 and spark41).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@baibaichen baibaichen force-pushed the pr1/enable-parquet-type-widening-suite branch from 556c23a to 4f0f7a9 Compare March 8, 2026 06:26
@github-actions
Copy link

github-actions bot commented Mar 8, 2026

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 8, 2026

Run Gluten Clickhouse CI on x86

@baibaichen baibaichen merged commit 2990280 into apache:main Mar 8, 2026
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BUILD CORE works for Gluten Core VELOX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[VL] Support type widening in Parquet reader (SPARK-40876)

2 participants